Attention is currently required from: Hoernchen.

laforge has posted comments on this change by Hoernchen. ( 
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email )

Change subject: add ext power detect & dev reset
......................................................................


Patch Set 7:

(2 comments)

File sysmoOCTSIM/main.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447/comment/e48c2160_02da6681?usp=email
 :
PS7, Line 334: {
the purpose here is to reset the board if it switches from bus-powered to 
self-powered? might be good to have a one-line comment about it here.


File sysmoOCTSIM/usb/device/usbdc.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447/comment/48e114fd_5c570e41?usp=email
 :
PS7, Line 323:          st = old_extpwer_state ? 0x0 : 0x1;
so all USB request to the device indicate the power status in return?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ied62450670dba2227daa96cbcd162cfe8414445a
Gerrit-Change-Number: 39447
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Comment-Date: Mon, 10 Mar 2025 17:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to