osmith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email )
Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy
......................................................................
src/rspro_client_fsm: fix osmo_stream_cli_destroy
Fix for:
Assert failed stream_cli_close(cli) == false
../../src_copy/libosmo-netif/src/stream_cli.c:1023
Reproducer in osmo-ttcn3-hacks:
./testenv.py run remsim -c client -t RemsimClient_Tests.TC_bank_disconnect
Suggested-by: Pau Espin Pedrol <pes...@sysmocom.de>
Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f
---
M src/rspro_client_fsm.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index d847f3b..63bd534 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -534,8 +534,9 @@
case SRVC_E_DISCONNECT:
if (srvc->conn) {
LOGPFSML(fi, LOGL_INFO, "Destroying existing connection
to server\n");
- osmo_stream_cli_destroy(srvc->conn);
+ struct osmo_stream_cli *conn = srvc->conn;
srvc->conn = NULL;
+ osmo_stream_cli_destroy(conn);
}
osmo_fsm_inst_state_chg(fi, SRVC_ST_INIT, 0, 0);
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f
Gerrit-Change-Number: 39920
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
