Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366?usp=email )

Change subject: library: Introduce NGAP Emulation
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

File library/NGAP_Functions.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366/comment/f9968865_7415567c?usp=email
 :
PS1, Line 3: 2019 by Harald Welte
Did Harald really write this code?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366/comment/714edbc8_743ed7b7?usp=email
 :
PS1, Line 20: f_NGAP_get_AMF_UE_NGAP_ID
Looks like WIP code? Returning `omit` in all cases does not look useful?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5aea8be12c54cf907e71bffe6456efb5e60eb203
Gerrit-Change-Number: 40366
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Sat, 24 May 2025 08:47:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to