Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367?usp=email )

Change subject: 5gc: initial
......................................................................


Patch Set 1:

(2 comments)

File 5gc/C5G_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/da7ff9f7_126fcca3?usp=email
 :
PS1, Line 265: var charstring id := testcasename();
Do we really want doing this in each and every testcase?
Why not just calling `testcasename()` where it's needed, i.e. in 
`f_init_one_ngran()`?


File Makefile:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/19d0e10c_ea424006?usp=email
 :
PS1, Line 63: PARALLEL_MAKE ?= -j4
unrelated change



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I867433c87c6da2f0d1f299245aedf4830acbf539
Gerrit-Change-Number: 40367
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Sat, 24 May 2025 08:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to