Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email )
Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 1: (2 comments) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40653/comment/8f844203_71434c02?usp=email : PS1, Line 1978: Create tlvp_val16be `tlvp_val16be` is already there, did you mean `tlvp_val16le`? https://gerrit.osmocom.org/c/osmo-sgsn/+/40653/comment/ffb5f194_299040c3?usp=email : PS1, Line 1979: osmo_swab16(tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)); I would avoid calling `tlvp_val16be()` and then swapping bytes. `tlvp_val16be()` is calling `osmo_load16be()` internally, so you can do: ``` osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 40653 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 14 Jul 2025 08:50:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
