fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40661?usp=email )
Change subject: s1gw_metrics: expose get_current_value/1
......................................................................
s1gw_metrics: expose get_current_value/1
This API will be used in a follow-up patch adding tests for metrics.
Change-Id: Ifd1d87dbf236379b39c7f70307a4a9d6540a9720
Related: SYS#7065
---
M src/s1gw_metrics.erl
1 file changed, 10 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw
refs/changes/61/40661/1
diff --git a/src/s1gw_metrics.erl b/src/s1gw_metrics.erl
index 00e603d..317012d 100644
--- a/src/s1gw_metrics.erl
+++ b/src/s1gw_metrics.erl
@@ -35,6 +35,7 @@
-module(s1gw_metrics).
-export([init/0,
+ get_current_value/1,
ctr_reset/1,
ctr_inc/1,
ctr_inc/2,
@@ -99,6 +100,7 @@
-type counter() :: [ctr | _].
-type gauge() :: [gauge | _].
+-type metric() :: counter() | gauge().
-spec register_all(Type, List) -> Result
@@ -109,13 +111,6 @@
lists:filter(fun(Name) -> exometer:new(Name, Type) =/= ok end, List).
--spec get_current_value(counter() | gauge()) -> integer().
-get_current_value(Name) ->
- Result = exometer:get_value(Name, value),
- {ok, [{value, PrevVal}]} = Result,
- PrevVal.
-
-
%% ------------------------------------------------------------------
%% public API
%% ------------------------------------------------------------------
@@ -126,6 +121,14 @@
[] = register_all(counter, ?S1GW_COUNTERS),
[] = register_all(gauge, ?S1GW_GAUGES).
+
+-spec get_current_value(metric()) -> integer().
+get_current_value(Name) ->
+ Result = exometer:get_value(Name, value),
+ {ok, [{value, Value}]} = Result,
+ Value.
+
+
%%%%%%%%%%%%%
%% CTR APIs
%%%%%%%%%%%%%
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40661?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ifd1d87dbf236379b39c7f70307a4a9d6540a9720
Gerrit-Change-Number: 40661
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
