Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email )
Change subject: Allow io_uring_submit batching just ahead of poll/select ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/1e55e1af_71945150?usp=email : PS4, Line 431: io_uring_submit(&g_ring.ring); > Done Not done https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/023b9662_88a06ae9?usp=email : PS4, Line 481: io_uring_submit(&g_ring.ring); Since this pattern is repeated in several places, I'd add a static "inline void io_uring_sched_submit()" function which does this. Then we easily spot places where the same thing needs to be done, and we don't forget updating all of them like it happened already in this version of the patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id34fe2ced32c63d15b14810e145744f7509064cc Gerrit-Change-Number: 40489 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:46:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andr...@eversberg.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de>
