Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email )
Change subject: Send multiple read/recvfrom/recvmsg SQEs in advance ...................................................................... Patch Set 8: Code-Review+1 (3 comments) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/657ede80_e8db1a91?usp=email : PS8, Line 113: uint8_t read_sqes; num_read_sqes? https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/2d0fe50f_685bd8b6?usp=email : PS8, Line 117: uint8_t read_count; reads_in_transit? reads_in_progress? File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/13ab340f_4efa41a4?usp=email : PS8, Line 152: msg = iofd_msgb_alloc(iofd); I think having each loop iteration in a separate function should make this easier to read and maintain. That also means this patch suddenly has half of modified lines. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id50a8900fa2fe6de553e5025feae7e1e8d501e30 Gerrit-Change-Number: 40494 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Mon, 28 Jul 2025 11:18:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
