Attention is currently required from: pespin.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email )

Change subject: Add multiple messages buffers to io_uring read operations
......................................................................


Patch Set 9:

(1 comment)

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/e05454a0_e5cc1d8d?usp=email
 :
PS9, Line 166:  if (idx == 0) {
> shouldn't this be "if (idx != io_len)" ?
the idea is to have keep the msgb buffers we could allocate. (in case of memory 
allocation problems.) if we could not allocate any buffer, we free our msghdr 
and return NULL.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4544b8fcbad5a266db748d6864d3ae93ee06bce
Gerrit-Change-Number: 40492
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Jul 2025 11:46:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to