Attention is currently required from: neels.

laforge has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/39741?usp=email )

Change subject: [1/6] personalization: refactor: drop ClassVarMeta use
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39741/comment/e4f16f47_c731ac46?usp=email :
PS9, Line 37: class ConfigurableParameter:
> There's no point about discussion whether abstract base classes and the 
> python library are useful or […]
I continue to see new patch versions with this change without seeing the above 
adressed.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051
Gerrit-Change-Number: 39741
Gerrit-PatchSet: 11
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Aug 2025 12:00:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Comment-In-Reply-To: laforge <lafo...@osmocom.org>

Reply via email to