Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email )
Change subject: Add environment variable to set io_uring size ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/d9256dee_d4604c92?usp=email : PS5, Line 56: #define IOFD_URING_MAXIMUM_SIZE 32768 I'm still wondering where is this maximum specified? Is it a kernel hardcoded value? liburing? Do we have a liburing define for this? https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/43a58613_76984c1c?usp=email : PS5, Line 112: /* 32768 is the maximum number of entries the Kernel can handle. */ Better move this comment to where IOFD_URING_MAXIMUM_SIZE is defined. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484 Gerrit-Change-Number: 40782 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:15:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
