Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email )
Change subject: S1GW: Add test case to test release of failed e-RABs during handover resource allocation ...................................................................... Patch Set 2: (7 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/a0d9c58d_8fe5c7f4?usp=email : PS2, Line 1131: in ERabIdxList erabs_failed := {}) > No more "in" churn please. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/dcdb6b75_1e216bd5?usp=email : PS2, Line 1706: var ERabIdxList erabs_admitted; : for (var integer i := 0; i < lengthof(g_pars.erabs); i := i + 1) { : erabs_admitted[i] := i; : } > See my comment about `f_ERabList_compose()` in previous patch. We cannot use f_ERabList_compose(), because we create an index list here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/5b6b506b_56557bc6?usp=email : PS2, Line 1720: f_ConnHdlr_tx_handover_ack(erabs_admitted, mme_ue_id, enb_ue_id, erabs_failed); : log("[eNB -> S1GW] -> MME: HANDOVER REQUEST ACKNOWLEDGE"); > We usually log first: […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/2a36c20c_c2459574?usp=email : PS2, Line 1726: for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) { : var ERabIdx idx := erabs_admitted[i]; : erabs[i] := g_pars.erabs[idx]; : } > See my comment about `f_ERabList_compose()` in previous patch. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/c084fd0a_b1651635?usp=email : PS2, Line 1736: for (var integer i := 0; i < lengthof(erabs_failed); i := i + 1) { : var ERabIdx idx := erabs_failed[i]; : erabs[i] := g_pars.erabs[idx]; : > See my comment about `f_ERabList_compose()` in previous patch. Done File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/0d8aa37b_31d1c3cc?usp=email : PS2, Line 955: f_ConnHdlr_handover_ack( > no need for this extra line in params. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/8d5e10a0_ea8eec41?usp=email : PS2, Line 962: for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) { : var ERabIdx idx := erabs_admitted[i]; : erabs_left[i] := g_pars.erabs[idx]; : > See my comment about `f_ERabList_compose()` in previous patch. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic14f560ae16b8386e58ac85f8af53b19d7c7a5c9 Gerrit-Change-Number: 41095 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 15 Sep 2025 08:56:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
