Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41100?usp=email )
Change subject: [REST] Implement Pfcp{AssocState,Heartbeat}
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File contrib/openapi.yaml:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41100/comment/03b4a155_a70a6288?usp=email
:
PS8, Line 46: post:
> looks like post and delete are not implemented yet.
Right.
> maybe mention this here in summary as comment?
The OpenAPI specification for `PfcpAssocSetup` and `PfcpAssocRelease` is
complete, so adding comments here makes no sense. I've added TODOs to
`rest_server.erl`.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41100?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Idc98952d46d8e224969da343dc29ef323c6ed813
Gerrit-Change-Number: 41100
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Sat, 27 Sep 2025 12:18:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <[email protected]>
