Attention is currently required from: keith, pespin. fixeria has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email )
Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/3398893b_f0566a9e?usp=email : PS4, Line 303: DB_STMT_SMS_DEL_EXPIRED > I'd prefer to keep you happy in this patch. I can remove the LIMIT clause. Thanks. > I'd propose to get rid of this one (EXPIRED) an replace its use in the code > with the other one, just plain old: DB_STMT_SMS_DEL_BY_ID Ack, this is exactly what I had in mind. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 7 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: keith <[email protected]> Gerrit-Comment-Date: Tue, 14 Oct 2025 08:34:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: keith <[email protected]>
