Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188?usp=email )
Change subject: MME-Tests: Add tests for emergency cappability indication ...................................................................... Patch Set 1: (4 comments) File mme/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/979eca67_b188c8de?usp=email : PS1, Line 344: if (lengthof(enl_tlv.emergencyNumberList) != g_pars.emerg_pars.numbers) { I see you're doing a lot of "manual" matching here. Why not defining templates for `EmergencyNumber` and `EmergencyNumberList`? This way you could have a template in `EmergParams` and simply do `match(attach_accept.emergencyNumberList, template)` here. File mme/MME_Tests_emergency.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/fb0be5fe_a277efa2?usp=email : PS1, Line 3: SGsAP related procedures copy-paste https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/54805032_f6b112f8?usp=email : PS1, Line 3: in in fixme https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/493e73f5_4cb4f0ea?usp=email : PS1, Line 4: 2025 Andreas Eversberg <[email protected]> I believe the copyright holder should be sysmocom. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d84486dd3826d0f60a3c06693118e36b01ecd2b Gerrit-Change-Number: 41188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 01 Oct 2025 16:10:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
