Attention is currently required from: fixeria, jolly, laforge, lynxis lazus, 
neels, osmith.

matanp has posted comments on this change by matanp. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email )

Change subject: vlr: Stop silent call before deduping subscribers
......................................................................


Patch Set 2:

(1 comment)

File src/libvlr/vlr.c:

https://gerrit.osmocom.org/c/osmo-msc/+/41131/comment/bfa95983_964bf63a?usp=email
 :
PS1, Line 651: gsm_silent_call_stop(
> Good point. If there's no silent call going on, `gsm_silent_call_stop()` will 
> log errors...
I added a check to make sure we stop only ongoing transactions



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If23f8b0e42d4a3a8bf1c8f5ca81b045834b6cccd
Gerrit-Change-Number: 41131
Gerrit-PatchSet: 2
Gerrit-Owner: matanp <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Fri, 10 Oct 2025 14:00:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to