Attention is currently required from: dexter.

fixeria has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/41229?usp=email )

Change subject: pySim-shell: set callback function to print formatted warnings
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
Honestly, this looks overengineered to me. Especially the `Info` class, which 
is a `Warning` but not really a warning. Why not using the standard logging 
module, which does have all the necessary facilities (logging categories, 
logging targets, etc.)? You can then define a logging target that prints 
messages using `cmd2`.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41229?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I187f117e7e1ccdb2a85dfdfb18e84bd7561704eb
Gerrit-Change-Number: 41229
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Sun, 19 Oct 2025 13:41:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to