Attention is currently required from: laforge, tempest, tnt, ttsou. fixeria has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-trx/+/41231?usp=email )
Change subject: trx: Fix tx/rx-sps 4 for USRP1 devices ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > should I fix it as the linter is suggesting? The multi-line function call > format it's complaining ab […] You're changing the existing code, which is not properly formatted in the first place. So I believe we can bypass the linter here. I can do that when the commit message is fixed. Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/41231/comment/a4df052b_0edaea13?usp=email : PS1, Line 9: The existing code sets the pingOffset variable to -7231(269 - 7500) with tx-sps = 4. The (apparent) correct value for pingOffset for tx/rx-sps 4 is 272. Please adjust the commit message formatting to avoid very long lines: wrap it to about 72 characters or so. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/41231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3b08c23a3e7d4a226cd23b9fe42558f596a63257 Gerrit-Change-Number: 41231 Gerrit-PatchSet: 1 Gerrit-Owner: tempest <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Reviewer: ttsou <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: tempest <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: tnt <[email protected]> Gerrit-Attention: ttsou <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 18:27:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tempest <[email protected]> Comment-In-Reply-To: laforge <[email protected]>
