Attention is currently required from: pespin. keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28342?usp=email )
Change subject: SMS UX optimisation: Deliver rx'd SMS right away ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'm not sure I'm fully following you tbh, because from your previous (full) > comment afaict you seem […] My dear Pau, The comparison with UDP ordering is somewhat absurd. 😊 About the ordering/disordering.. have you ever really, actually, you know, as a human being, noticed that one SMS arrived (what are we talking here.. max 1 second, 2?) before another? I would imagine more likely you got some notification of SMS and by the time you looked at the SMS, you see them in order of timestamp. I'm looking at this from a humanitarian, and you're looking at it from a somewhat staunch technical POV. In the real world, one might expect that a message I just sent is more relevant than the one I sent two weeks (or months) ago. But look - I don't CARE! We can do what you suggest, for sure. The chances of running into the situation where a just sent SMS provokes the sending of an older, and only that older SMS is highly unlikely, well I outlined a remote possibility for it above, but whatever... It is very unlikely to negatively affect the human experience of it. Anyway, I'm expending energy here now that is limited, so I may or may not get around to doing...what I suggested above - RX of SMS triggers queue to THAT recipient, and that recipient only, in order, by date, id, whatever (actually number of failed retries, IIRC is the current criteria) In my real world experience of the real world problem of real world people who send real world SMS, your solution will also suffice, as I have not actually observed a situation where the situation you described occurred, because; with this patch in place, the first message was ALREADY DELIVERED, damn it. And if it wasn't, then this new message isn't going to be either. I've been running this patch for a long time now, and it works.. you know.. in the real world 😊 I thought it might be an idea to have it in for congress... but yeah.. limited motivation.. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 4 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 04 Nov 2025 19:20:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: keith <[email protected]>
