Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 8: (4 comments) File src/ss7_as.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4fad13b2_58f54c9d?usp=email : PS8, Line 6: #include <osmocom/core/hashtable.h> > #ifdef WITH_TCAP_LOADSHARING Does the include hurt? I would try to prevent cluttering #ifdefs everywhere. File src/ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/7db15e8e_cb951838?usp=email : PS8, Line 545: case OSMO_SS7_AS_TMOD_LOADSHARE: > #ifdef WITH_TCAP_LOADSHARING […] This is fine. https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c09cd7a6_106d8467?usp=email : PS8, Line 634: > extra line not needed. Acknowledged File src/ss7_as_loadshare_tcap.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/048f1c72_2802159a?usp=email : PS8, Line 14: #ifdef WITH_TCAP_LOADSHARING > YOu can remove this, simply don't even include it if not requested by > configure... No, I want to keep it here because of the #else branch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:10:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
