Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email )

Change subject: mtp: Improve mtp_sap/ss7_user APIs
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

File TODO-RELEASE:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411/comment/d8f87ff7_9f9b6dc7?usp=email
 :
PS3, Line 13: libosmo-sigtran add   osmo_ss7_user_mtp_sap_prim_down()
maybe note here that ss7_user APIs (that were not used by anyone yet) were 
reworked?


File src/mtp_sap.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411/comment/f4e1f5ba_56c8cad8?usp=email
 :
PS3, Line 100:          rc = -1;
maybe add a break here for consistency?



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22
Gerrit-Change-Number: 41411
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 14 Nov 2025 13:10:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to