Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41471?usp=email
to look at the new patch set (#2).
Change subject: GSUP: PDP Context ID: start at 1
......................................................................
GSUP: PDP Context ID: start at 1
In OsmoHLR, PDP Contexts can have IDs <1-10>. 0 is used internally to
mark a profile slot as disabled:
https://gitea.osmocom.org/cellular-infrastructure/osmo-hlr/src/commit/d4b4548589f929d7c888ad213bd601ab2a421d8a/src/hlr_vty.c#L201
HLR Test TC_gsup_ul_subscriber_data in osmo-ttcn3-hacks also makes this
assumption:
https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/commit/85276b94c474bb649a0c4893b760c7b76f1f342e/hlr/HLR_Tests.ttcn#L1165-L1172
However the new GSUP implementation in PyHSS started its IDs at 0. I've
suggested to start it at 1 here:
https://github.com/nickvsnetworking/pyhss/pull/277/files/4b6da744743877806810b6eade937d2360eb0fbf#r2545727324
Change-Id: I9c39002cb7f7dd81ae0f1f0f9d80df1aaf399f48
---
M common/chapters/gsup.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/71/41471/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41471?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9c39002cb7f7dd81ae0f1f0f9d80df1aaf399f48
Gerrit-Change-Number: 41471
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
