laforge has submitted this change. (
https://gerrit.osmocom.org/c/pysim/+/41466?usp=email )
Change subject: card_key_provider: remove unnecessary class property definitions
......................................................................
card_key_provider: remove unnecessary class property definitions
The two properties csv_file and csv_filename are defined by the
constructor anyway, let's remove the declaration in the class body
because it is not needed.
Change-Id: Ibbe8e17b03a4ba0041c0e9990a5e9614388d9c03
---
M pySim/card_key_provider.py
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py
index 66e96e9..0827b70 100644
--- a/pySim/card_key_provider.py
+++ b/pySim/card_key_provider.py
@@ -173,9 +173,6 @@
class CardKeyProviderCsv(CardKeyProvider):
"""Card key provider implementation that allows to query against a
specified CSV file."""
- csv_file = None
- filename = None
-
def __init__(self, csv_filename: str, transport_keys: dict):
"""
Args:
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41466?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibbe8e17b03a4ba0041c0e9990a5e9614388d9c03
Gerrit-Change-Number: 41466
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
