Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email )
Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 4: (5 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/bca5d7b1_fe5f280e?usp=email : PS4, Line 16: # cmd2 >= 2.3.0 has deprecated the bg/fg in favor of Bg/Fg :( Other than `YELLOW`, `cmd2` API is not used in this script. I would avoid importing it just because you want a color in logging. I believe you can just use an ASCII color code? https://gerrit.osmocom.org/c/pysim/+/41508/comment/8cd99406_fee94e2b?usp=email : PS4, Line 225: log.info("CSV file: %s" % opts.csv) BTW, for logging API it's recommended to use lazy format-sting evaluation: ``` log.info("CSV file: %s", opts.csv) ``` https://gerrit.osmocom.org/c/pysim/+/41508/comment/ee7844fb_d607dda4?usp=email : PS4, Line 227: if not csv_file: Does `open()` return `None` at all? It raises an exception on error. File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/3cf45c38_64837df4?usp=email : PS4, Line 242: break; cosmetic: semicolon is not needed here File setup.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/1548a453_b40f2048?usp=email : PS4, Line 37: psycopg2-binary Not blocking here, but do we really want this as a required dependency? This list is already quite long, giving headaches to those trying to package pySim... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 26 Nov 2025 17:49:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
