pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email )


Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
......................................................................

gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS

The pdp_status is actually encoded as little endian,
but there is no tlvp_val16le yet.

Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c
(cherry picked from commit b79797d0568ffd757540f6307d538135bdfa01b8)
---
M src/sgsn/gprs_gmm.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/75/41575/1

diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index 7a4ea20..d70ceec 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -2009,7 +2009,8 @@
        /* Look at PDP Context Status IE and see if MS's view of
         * activated/deactivated NSAPIs agrees with our view */
        if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) {
-               uint16_t pdp_status =  tlvp_val16be(&tp, 
GSM48_IE_GMM_PDP_CTX_STATUS);
+               /* TODO: Use tlvp_val16le when available */
+               uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, 
GSM48_IE_GMM_PDP_CTX_STATUS));

                process_ms_ctx_status(ctx, pdp_status);


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: osmo-sgsn
Gerrit-Branch: pespin/rel-1.13.0
Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c
Gerrit-Change-Number: 41575
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-CC: lynxis lazus <[email protected]>

Reply via email to