Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41613?usp=email )
Change subject: sctp_proxy: add _from_{enb,mme} variants of sctp_send/2
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41613/comment/833502c5_03324be1?usp=email
:
PS1, Line 13: and clarify the direction by adding _from_{enb,mme} to function
names.
probably sctp_send_uplink and _downlink would be clearer, but fine anyway.
Even "to_mme" or "to_enb" would be more clearer imho.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41613?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I388137e27ea5000f22e7a5b58d1ffcfd9caa1475
Gerrit-Change-Number: 41613
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 05 Dec 2025 17:16:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
