pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/41648?usp=email )
Change subject: bts-trx: Set max TRXD buf size to UINT16_MAX
......................................................................
bts-trx: Set max TRXD buf size to UINT16_MAX
Otherwise trying to allocate a msgb from it fails:
In file included from /git/osmo-bts/src/osmo-bts-trx/l1_if.h:9,
from /git/osmo-bts/src/osmo-bts-trx/trx_if.c:50:
/git/osmo-bts/src/osmo-bts-trx/trx_if.c: In function ‘trx_if_send_burst’:
/git/osmo-bts/src/osmo-bts-trx/trx_if.h:6:33: error: unsigned conversion from
‘int’ to ‘uint16_t’ {aka ‘short unsigned int’} changes value from
65536’ to ‘0’ [-Werror=overflow]
6 | #define TRXD_MSG_BUF_SIZE 65536
| ^~~~~
/git/osmo-bts/src/osmo-bts-trx/trx_if.c:1126:48: note: in expansion of macro
‘TRXD_MSG_BUF_SIZE’
1126 | trx_data_last_msg = msgb_alloc(TRXD_MSG_BUF_SIZE,
"tx_trxd");
| ^~~~~~~~~~~~~~~~~
Change-Id: I980faea05dee405c974636f41ee723659d9c5229
---
M src/osmo-bts-trx/trx_if.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/48/41648/1
diff --git a/src/osmo-bts-trx/trx_if.h b/src/osmo-bts-trx/trx_if.h
index 3a22a1b..e0ef84d 100644
--- a/src/osmo-bts-trx/trx_if.h
+++ b/src/osmo-bts-trx/trx_if.h
@@ -3,7 +3,7 @@
/* TRXC read/send buffer size */
#define TRXC_MSG_BUF_SIZE 1500
/* TRXD read/send buffer size (max. lo MTU) */
-#define TRXD_MSG_BUF_SIZE 65536
+#define TRXD_MSG_BUF_SIZE 65535U
struct trx_dl_burst_req;
struct trx_l1h;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41648?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I980faea05dee405c974636f41ee723659d9c5229
Gerrit-Change-Number: 41648
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
