Attention is currently required from: fixeria.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/41649?usp=email )

Change subject: bts-trx: Convert trx clk socket to iofd
......................................................................


Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/41649/comment/7a20e060_99a1f25c?usp=email
 :
PS1, Line 9: use
> nitpick: use twice
Done


File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/41649/comment/65497424_cc4160d8?usp=email
 :
PS1, Line 1355: int rc;
> rename to `fd` or `sfd`?
Done


https://gerrit.osmocom.org/c/osmo-bts/+/41649/comment/407dd634_5b297c85?usp=email
 :
PS1, Line 1371: osmo_iofd_setup
> cosmetic: line too long, please wrap
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41649?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia33028a657e7d5dee1a4994b8d6ba33ddea892ec
Gerrit-Change-Number: 41649
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 12 Dec 2025 11:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to