Attention is currently required from: fixeria, pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/41650?usp=email )

Change subject: bts-trx: Convert TRXC and TRXD sockets to iofd
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/41650/comment/9725660a_53887daa?usp=email
 :
PS4, Line 750:  /* nothing to be done here */
I found the comment from the previous patch more useful:

```suggestion
        /* libosmocore before change-id 
I0c071a29e508884bac331ada5e510bbfcf440bbf requires write call-back
         * even if we don't care about it */```



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41650?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I239f91efad43eabd280caf9f852c3aefbc729eaf
Gerrit-Change-Number: 41650
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 12 Dec 2025 15:06:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to