Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41660?usp=email )
Change subject: bts-trx: define TRXD_MSG_BUF_SIZE as a more realistic lower value ...................................................................... Patch Set 4: (2 comments) File src/osmo-bts-trx/trx_if.h: https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/d8ca32d6_8a49027d?usp=email : PS3, Line 11: OSMO_MAX(2 * (GSM_BURST_LEN + 2), (EGPRS_BURST_LEN + 2)) > `EGPRS_BURST_LEN` is known to be 3 times greater than `GSM_BURST_LEN` > (because 8-PSK fits 3 bits per […] I know, see last comment line. Still, this code here is resolved at compile time as a constant expression by any decent compiler, and it auto-explains how the value is calculated. https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/ff45fa7d_07f4d5c5?usp=email : PS3, Line 12: TRXD_BURST_SIZE_MAX * TRX_NR_TS > Here you're accounting for up to 8 8-PSK bursts, you're taking into account > those 2 dummy bytes (fro […] Ack, I'll add some extra bytes for the header. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41660?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic725e26637f8c116cfd5e64ff54d60a1d1bf9b87 Gerrit-Change-Number: 41660 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 12 Dec 2025 15:25:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
