Attention is currently required from: daniel, fixeria, jolly, laforge, osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41671?usp=email )

Change subject: io_uring: RECVMSG_SENDMSG: Reset fd to blocking after 
osmo_fd_register() workaround
......................................................................


Patch Set 3:

(1 comment)

File src/core/osmo_io_uring.c:

https://gerrit.osmocom.org/c/libosmocore/+/41671/comment/2d55ddfb_93c8e70b?usp=email
 :
PS2, Line 614:   * NOITE: osmo_fd_setup() sets iofd->fd as O_NONBLOCK. */
> Nitpick: It's not osmo_fd_setup(), but osmo_fd_register() that calls fcntl() 
> and sets the fd nonbloc […]
Ah yes typo thanks.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41671?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idba623730230bc049b827e51b058cd64d23b730f
Gerrit-Change-Number: 41671
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Tue, 16 Dec 2025 11:03:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: daniel <[email protected]>

Reply via email to