Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email )

Change subject: logging: change gsmtap target to use wqueue by default
......................................................................


Patch Set 1:

(1 comment)

File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/b1ffb4e3_d8d672f6?usp=email
 :
PS1, Line 1047:                 if (tgt->tgt_gsmtap.ofd_wq_mode)
> I would do exactly that if `struct gsmtap_inst` were public, but it's not. […]
Then please add a new public API in core with 
gsmtap_inst_get_blocking_io(target->tgt_gsmtap.gsmtap_inst).

Let's not break ABI.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d8c953a5b467ce4396d2d20ca6fa72a749723c0
Gerrit-Change-Number: 41685
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 16 Dec 2025 15:03:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to