fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email )
Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
......................................................................
rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
Otherwise the TA loop would end up using whatever value was set
previously. Let's assume TA=0 if not indicated by the BSC.
Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2
---
M src/common/rsl.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 7931a17..1104ef8 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2064,6 +2064,8 @@
/* 9.3.24 Timing Advance */
if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1))
lchan->ta_ctrl.current = *TLVP_VAL(&tp, RSL_IE_TIMING_ADVANCE);
+ else /* assume TA=0 if not indicated by the BSC */
+ lchan->ta_ctrl.current = 0;
/* 9.3.31 (TLV) MS Power Parameters IE (vendor specific) */
if ((ie = TLVP_GET(&tp, RSL_IE_MS_POWER_PARAM)) != NULL) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2
Gerrit-Change-Number: 39829
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
