Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41712?usp=email )
Change subject: pyshark_gsmtap: Adjust display filter for some wireshark versions ...................................................................... Patch Set 1: (1 comment) File pySim/apdu_source/pyshark_gsmtap.py: https://gerrit.osmocom.org/c/pysim/+/41712/comment/d04deefb_8a7a5900?usp=email : PS1, Line 87: pyshark_inst = pyshark.FileCapture(pcap_filename, display_filter='gsmtap.type == 4', use_json=True, keep_packets=False) I have tried to check back why this patch fails the unit-tests. The GSMTAP header in the test trace looks correct. The type is 4. For me the test also fails. Wireshark seems to have problems as well. With gsmtap.type == 4 no packets are shown. The wireshark on my system is: Version 4.0.17 (Git v4.0.17 packaged as 4.0.17-0+deb12u1), The pyshark version is 0.6p, li { white-space: pre-wrap; } -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I53c1c8ed58a82c37cd4be4af3890af21da839e86 Gerrit-Change-Number: 41712 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 18 Dec 2025 15:35:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
