Attention is currently required from: laforge, neels.

dexter has posted comments on this change by laforge. ( 
https://gerrit.osmocom.org/c/pysim/+/41674?usp=email )

Change subject: ts_51_011/EF.SMSP: Fix parsing of parameter_indicators
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/41674/comment/49d82687_91abe667?usp=email :
PS2, Line 11: during encode.
I was a bit confused by the Const(7,...) in the code... I have looked it up in 
the spec. Maybe "...considers '111' to be the default." is more precise?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41674?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibe24a07f5f73d875d2077fa55471dbfc4e90da23
Gerrit-Change-Number: 41674
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to