Attention is currently required from: fixeria, pespin.

laforge has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email )

Change subject: 5gc: Test UE Triggered Service Request
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

File 5gc/ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747/comment/7748944a_74bd4194?usp=email
 :
PS3, Line 410:          var PDUSessionResourceSetupItemSURes it_resp;
             :          it_resp := 
f_pdu_handle_session_resource_setup_item_su(li_req[i]);
             :          if (i == 0) { /* min 1 item in list doesn't allow 
previously allocating an empty list */
             :                  li_resp := { it_resp };
             :          } else {
             :                  li_resp := li_resp & { it_resp };
             :
> I'll keep it as is to keep it in line with other instances of this code in 
> this file, since I think  […]
all such instances can possibly (and probably should) be rewritten according to 
the suggestion of @fixeria - but that's indeed unrelated to this specific patch.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41747?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I65cf7844d11be55d9d5c8e31fd87a3c72e6a607b
Gerrit-Change-Number: 41747
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 07 Jan 2026 12:51:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to