Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39745?usp=email )
Change subject: personalization: refactor AlgorithmID, K, Opc ...................................................................... Patch Set 10: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39745/comment/1ff15e96_dcd87e98?usp=email : PS8, Line 571: allow_len = int(128/8) # length in bytes (from BinaryParam) > problem still seems apparent in new patchset 10? yes, that is accurate. so -- if the Algorithm chosen is TUAK, then the K length can be 256bit, right? That is a first -- the valid range of one ConfigurableParam being influenced by the value of another. I will simply allow both lengths in K and rely on the user to choose the right length. Then certain downstream projects can later additionally validate the user input to match the Algorithm choice, like it warns against duplicate keys. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6296fdcfd5d2ed313c4aade57ff43cc362375848 Gerrit-Change-Number: 39745 Gerrit-PatchSet: 10 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 07 Jan 2026 23:30:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
