Attention is currently required from: laforge.

neels has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/40094?usp=email )

Change subject: personalization: set example input values
......................................................................


Patch Set 7:

(2 comments)

Patchset:

PS6:
> earlier comments from August (!) 2025 have still not been adressed 😞
the review was essentially stuck at an earlier patch so i am getting to this 
part only now...


Commit Message:

https://gerrit.osmocom.org/c/pysim/+/40094/comment/2e3e2313_3818ba93?usp=email :
PS2, Line 11: This is useful for user interaction, to prefill an input field 
that
            : indicates a valid input to modify to taste.
> For parameters that actually have a sane default value, I agree it makes 
> sense to have them stored h […]
ok, makes sense, I will definitely at least rename it.

The most relevant point is that in pysim, this is merely information provided, 
and not used for anything.
Whether we do a prefilled input field with this content needs to be discussed 
in the downstream project (SYS#7822)



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40094?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2672fedcbc32cb7a6cb0c233a4a22112bd9aae03
Gerrit-Change-Number: 40094
Gerrit-PatchSet: 7
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 08 Jan 2026 00:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to