Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email )
Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... Patch Set 2: (2 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785/comment/1b5e4913_0cc54abc?usp=email : PS2, Line 3853: if (first_after_wait) { : /* It may happen that BTS transmits SACCH before it receives our RSL MS POWER CONTROL: */ : log("Power level := ", l1h.ms_power_lvl, " does not ", : "match the signaled (RSL) power level := ", power_level); : first_after_wait := false; : repeat; : AFAIU, the idea of this patch is to ignore the first DL SACCH block. This can be done in a slightly more elegant way by doing this before the alt-statement: ``` /* ignore the first DL SACCH block */ L1CTL.trigger(tr_L1CTL_DATA_IND(g_chan_nr, tr_RslLinkID_SACCH(?))); ``` The `trigger` statement will keep blocking and discarding messages until a message matching the given template is received. Here's an extract from the language specification: > Stand-alone trigger > > The trigger operation can be used as a stand-alone statement in a behaviour > description. In this latter case the trigger operation is considered to be > shorthand for an alt statement with two alternatives (one alternative > expecting the message and another alternative consuming all other messages > and repeating the alt statement, see ETSI ES 201 873-4 [1]). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785/comment/b8d749a9_d5225d5b?usp=email : PS2, Line 3860: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, Please revert this change. It's not strictly needed here and makes the code harder to read. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:30:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
