Attention is currently required from: jolly, laforge, pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email )
Change subject: ta_control: Fix skip_block_num not reset when switching TS to PDCH ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Patchset: PS2: I have looked through the code, it does what the commit message says. File include/osmo-bts/ta_control.h: https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/1d3b0fc3_82c0e4d6?usp=email : PS2, Line 6: maybe remove the line break? File src/common/ta_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/7d3451b5_d3037c8d?usp=email : PS2, Line 47: /* Trigger loop on first TA input: */ Maybe put this comment above the function? (I guess both assignments are required for the trigger) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d Gerrit-Change-Number: 41790 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: jolly <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 09 Jan 2026 16:41:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
