Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )
Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 1: (3 comments) File include/osmocom/core/logging.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/6e974260_e4f9e270?usp=email : PS1, Line 447: struct log_target *log_target_create_web(); Bad function definition - struct log_target *log_target_create_web() should probably be struct log_target *log_target_create_web(void) File src/core/logging_web.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/00e26cdf_df101bd5?usp=email : PS1, Line 84: struct log_target *log_target_create_web() Bad function definition - struct log_target *log_target_create_web() should probably be struct log_target *log_target_create_web(void) File src/vty/telnet_interface_dummy.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/6a94b245_618be454?usp=email : PS1, Line 74: } void function return statements are not generally useful -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 10 Jan 2026 21:14:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
