Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41779?usp=email )
Change subject: personalization: refactor SmspTpScAddr ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41779/comment/08b50116_023e1ca5?usp=email : PS1, Line 362: val must be a tuple (international[bool], digits[str]) > this should be given as type annotation instead of a comment. […] This is a specific implementation of an abstract class method. I don't want a linter to tell us that the subclass is not allowed to change the function signature or something. Python itself really doesn't care. so why spend time looking up how to type hint a tuple with a bool and a str in it. apparently i can write ":tuple[bool,str]" or ":(bool,str)" .. are they equivalent? .. since the type isn't enforced, it's hard to tell whether i'm just making it up. so i originally decided to just write a short comment, as in, to not spread out this weirdly complex fringe detail that is based in laguage evanglism, far from practical usefulness, and not spend more time on it than i need at this point. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2600369e195e9f5aed7f4e6ff99ae273ed3ab3bf Gerrit-Change-Number: 41779 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Sun, 11 Jan 2026 03:39:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
