pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email )
Change subject: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx
primitive count
......................................................................
bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count
Even with latest changes I can still sometimes run into up to 6 FNs less
than the currently minimum expected. That's usually 1-2 primitives less,
which in the number of >100 we are receiving over 5 seconds, seems like
a plausible drift.
Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 1df5aa5..26fe18d 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -6116,7 +6116,7 @@
/* verify the number of frames expired matches our expectation */
const float c_GSM_FN_DURATION_MS := 4.61538;
var float fn_expected := test_duration * 1000.0 / c_GSM_FN_DURATION_MS;
- var template integer t_fn_expected :=
f_tolerance(float2int(fn_expected), 1, 100000, 20);
+ var template integer t_fn_expected :=
f_tolerance(float2int(fn_expected), 1, 100000, 30);
if (not match(fn_expired, t_fn_expected)) {
setverdict(fail, "Number of TDMA Frames (", fn_expired, ") not
matching ", t_fn_expected);
}
@@ -6204,7 +6204,7 @@
/* verify the number of frames expired matches our expectation */
const float c_GSM_FN_DURATION_MS := 4.61538;
var float fn_expected := test_duration * 1000.0 / c_GSM_FN_DURATION_MS;
- var template integer t_fn_expected :=
f_tolerance(float2int(fn_expected), 1, 100000, 20);
+ var template integer t_fn_expected :=
f_tolerance(float2int(fn_expected), 1, 100000, 30);
if (not match(fn_expired, t_fn_expected)) {
setverdict(fail, "Number of TDMA Frames (", fn_expired, ") not
matching ", t_fn_expected);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6
Gerrit-Change-Number: 41783
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
