Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843?usp=email )

Change subject: logging: Improve file & stderr log documentation
......................................................................


Patch Set 2:

(2 comments)

File common/chapters/logging.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843/comment/8479c207_e7f061c1?usp=email
 :
PS2, Line 320: _blocking-io_ parameter. This I/O mode should not be used in any 
osmocom program
> How about referring to the "blocking-io" section from the previous patch on 
> details about why this s […]
I think this part is important enough to have it covered and repeated here. In 
the end somebody reading this section to configure a logging file doesn't 
necessarily need to read about a gsmtap log target, which has tons more of 
different context.


https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843/comment/bb448235_1b8b833b?usp=email
 :
PS2, Line 322: block the thread for an un specified (potentially long or event 
infinite) amount
> ```suggestion […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I90114f634ae0411e58d2f3da86d5a2e470b4d828
Gerrit-Change-Number: 41843
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Thu, 15 Jan 2026 10:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>

Reply via email to