Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/41849?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add --disable-syslog-logging configure option
......................................................................
Add --disable-syslog-logging configure option
Right now syslog logging support is built in automatically based on
syslog.h being built at compile time. That's not desirable; as with
other dependencies make sure there's an explicit configure option for
it. Leave it enabled by default since most systems come with syslog.h
and it's a feature nice to have by default. It is disabled explicitly
when compiling for arm-none-eabi since the toolchain doesn't have
syslog.h.
Take the chance to completelly skip compiling the logging_syslog.c file
if support for syslog logging is disabled.
Change-Id: Ifc54d60e24547696b3059b6eb75572f8c84874d0
---
M configure.ac
M contrib/jenkins_arm.sh
M src/core/Makefile.am
M src/core/logging.c
M src/core/logging_syslog.c
M src/vty/logging_vty.c
6 files changed, 29 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/41849/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41849?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifc54d60e24547696b3059b6eb75572f8c84874d0
Gerrit-Change-Number: 41849
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <[email protected]>