pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/41848?usp=email )
Change subject: vty: Fix extern var declared inside ifdef
......................................................................
vty: Fix extern var declared inside ifdef
"extern struct host host;" was declared inside "ifdef HAVE_SYSLOG_H",
but it is actually needed unconditionally because it's also used in the
gsmtap log target, which is always built.
Change-Id: I9d769ff007a4eaf613691a0491b0b4e07472df98
---
M src/vty/logging_vty.c
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index 84e3331..128b23a 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -39,6 +39,9 @@
#include <osmocom/vty/telnet_interface.h>
#include <osmocom/vty/logging.h>
+/* From VTY core code. Used by gsmtap and syslog targets. */
+extern struct host host;
+
#define LOG_STR "Configure logging sub-system\n"
#define LEVEL_STR "Set the log level for a specified category\n"
@@ -656,9 +659,6 @@
[7] = LOG_LOCAL7
};
-/* From VTY core code */
-extern struct host host;
-
static int _cfg_log_syslog(struct vty *vty, int facility)
{
struct log_target *tgt;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41848?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d769ff007a4eaf613691a0491b0b4e07472df98
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
