Attention is currently required from: laforge, lynxis lazus. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41836?usp=email )
Change subject: Fix esim.saip.ProfileElementSequence.remove_naas_of_type ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: To me this looks ok and apparently it was also tested in practice. Commit Message: https://gerrit.osmocom.org/c/pysim/+/41836/comment/ca3c101e_e59a2d47?usp=email : PS1, Line 28: the future. I think having unittests would be very helpful. This would also make reviewing easier. At the moment I find it a bit hard to follow those SAIP related patches. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88d862d751198c3d1648ab7f11d6e6a8fdbc41c9 Gerrit-Change-Number: 41836 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 12:39:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
