Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39747?usp=email )
Change subject: personalization: refactor SdKey ...................................................................... Patch Set 13: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39747/comment/cb05b4d2_246c128c?usp=email : PS3, Line 296: def _apply_sd(cls, pe: ProfileElement, value): > Done I think this was where I took the idea from: https://www.geeksforgeeks.org/python/private-methods-in-python/ I didn't know that double underscore method/function names were explicitly reserved for python internal stuff, but given that most of the python internals start with a double underscore you may have a point. In any case, don't let me block you with this. Just wanted to share a thought. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I427ea851bfa28b2b045e70a19a9e35d361f0d393 Gerrit-Change-Number: 39747 Gerrit-PatchSet: 13 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 12:54:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: dexter <[email protected]>
