Attention is currently required from: daniel, fixeria, laforge, neels, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/41876?usp=email ) Change subject: Avoid marking rx PFCP Assoc Setup Req as duplicate ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Note, this scenario happened in https://jenkins.osmocom.org/jenkins/job/ttcn3-upf-test/1233/ , where UPF_Tests.TC_session_est_noop failed because our TTCN "cpf" initializes the Tx SeqNr with (PFCP_Emulation.ttcn:) g_next_sequence_nr_state := (1 + f_rnd_int(1000)) * 10000; So if two (more or less) consecutive tests obtain the same SeqNr through f_rnd_int, osmo-upf would ignore the PFCP Assoc Setup Req because it'd say it's a duplicate. As a result, next messages may also be marked as duplicate if they match the previous test. I think we are not yet clearing up the Tx and Rx retrans/duplicate queues, but we should probably clean them up when handling a Rx PFCP ASSOC SETUP REQ (or transmitting it). -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/41876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ia461550e6791aaf00d18e0310bb4f17fdd2a3f65 Gerrit-Change-Number: 41876 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 17:52:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
