Attention is currently required from: fixeria, phcoder. dexter has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email )
Change subject: Print SMSC in pySim-read.py ...................................................................... Patch Set 15: Code-Review+1 Verified+1 (1 comment) Patchset: PS15: I have tried this out and it works fine. I have also set the EF.SMSP record 1 to all FF to see what happens. No problem, it just shows "SMSC: " I would suggest to indent the SMSC: output to make more clear that it is related to SMSP. (similar to SIM Service Table, there you have the hex string and below are the parsed results with an indentation. Maybe also print "SMSC: (none)" in case it is not set. In any case, those are just cosmetic suggestions. I think its ok the way it is and I don't want to block you. Also the output of pySim-read.py has some consistency issues here and there anyway. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 15 Gerrit-Owner: phcoder <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: phcoder <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 20 Jan 2026 10:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
